Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up compat BoundaryValDiffEq #657

Closed
wants to merge 1 commit into from
Closed

Conversation

dehann
Copy link
Contributor

@dehann dehann commented Oct 11, 2023

Hi, I found the following compat issue. Will let PR CI tests run and see if there are any issues.

@dehann
Copy link
Contributor Author

dehann commented Oct 11, 2023

Not sure why CompatHelper did not catch this. I looked around for related issues or PR but didn't immediately see one.

@kellertuer
Copy link
Member

Interesting; it might be that CompatHelper does not check weak dependencies? At least the CI runs do not look like it would consider those; maybe we should check that those are included as well then.

@kellertuer
Copy link
Member

Yes, my impression was correct, see JuliaRegistries/CompatHelper.jl#452

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #657 (ff58e67) into master (106a8f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         106      106           
  Lines       10481    10481           
=======================================
  Hits        10400    10400           
  Misses         81       81           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mateuszbaran
Copy link
Member

Thanks! Before merging it would be good to check if BoundaryValueDiffEq v5 is actually used on CI.

@mateuszbaran
Copy link
Member

Hm, there seems to be a huge problem with BoundaryValueDiffEq v5

@mateuszbaran
Copy link
Member

I will close this in favor of #672 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update dep of BoundaryValueDiffEq.jl to v5.
3 participants