Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap adjoint calls in Matrix #56

Closed
wants to merge 2 commits into from
Closed

Wrap adjoint calls in Matrix #56

wants to merge 2 commits into from

Conversation

ararslan
Copy link
Member

Fixes #55.

@ararslan
Copy link
Member Author

Test failures (surely unrelated) reported at #57.

@stevengj
Copy link
Member

These should be transposes, not adjoints. Why can’t we use .'?

@ararslan
Copy link
Member Author

.' is deprecated in 0.7.

@ararslan
Copy link
Member Author

This will need #58 in order to pass CI.

@martinholters
Copy link
Collaborator

From poking at this locally, it looks like this does not need #58 anymore (due to better deprecations in Julia, I guess). It suffers from the A_mul_B! etc. rename, though. But against an AbstractFFTs with JuliaMath/AbstractFFTs.jl#10 in, just adding

if VERSION <= v"0.7.0-DEV.3204"
    import Base.A_mul_B!
    const mul! = A_mul_B!
else
    import Compat.LinearAlgebra.mul! # Note: Need to bump Compat version in REQUIRE
end

doing s/A_mul_B!/mul!/ and fixing up the two lines in runtests.jl that invoke A_mul_B! and A_ldiv_B!, respectively, I get the tests to pass.

@appleparan
Copy link
Contributor

appleparan commented Feb 25, 2018

Bump! We now have JuliaMath/AbstractFFTs.jl#10 and can I expect to be merged this with #58?

@staticfloat
Copy link
Collaborator

Bump! This broke a downstream package on 0.7 (AuditoryFilters), so it'd be nice to get this sorted soon.

@ararslan
Copy link
Member Author

Sorry for letting this languish for so long. Once JuliaLang/METADATA.jl#13833 is merged we should be in better shape here.

@ararslan ararslan closed this Mar 14, 2018
@ararslan ararslan reopened this Mar 14, 2018
@ararslan ararslan mentioned this pull request Mar 14, 2018
@ararslan
Copy link
Member Author

Incorporated into #64

@ararslan ararslan closed this Mar 14, 2018
@ararslan ararslan deleted the aa/adjoint-redux branch March 14, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants