-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap adjoint calls in Matrix #56
Conversation
Test failures (surely unrelated) reported at #57. |
These should be transposes, not adjoints. Why can’t we use |
|
7c6ccc3
to
bffe3d1
Compare
This will need #58 in order to pass CI. |
From poking at this locally, it looks like this does not need #58 anymore (due to better deprecations in Julia, I guess). It suffers from the if VERSION <= v"0.7.0-DEV.3204"
import Base.A_mul_B!
const mul! = A_mul_B!
else
import Compat.LinearAlgebra.mul! # Note: Need to bump Compat version in REQUIRE
end doing |
Bump! We now have JuliaMath/AbstractFFTs.jl#10 and can I expect to be merged this with #58? |
Bump! This broke a downstream package on 0.7 (AuditoryFilters), so it'd be nice to get this sorted soon. |
Sorry for letting this languish for so long. Once JuliaLang/METADATA.jl#13833 is merged we should be in better shape here. |
Incorporated into #64 |
Fixes #55.