Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbounds for trailing/missing dimensions. #566

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

N5N3
Copy link
Contributor

@N5N3 N5N3 commented Oct 30, 2023

close #562.

@N5N3 N5N3 force-pushed the cbfix branch 2 times, most recently from 023f184 to 1d00d5e Compare October 30, 2023 15:36
@mkitti
Copy link
Collaborator

mkitti commented Oct 30, 2023

Why is CI stalled?

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b617f6) 87.85% compared to head (4113d66) 87.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   87.85%   87.87%   +0.01%     
==========================================
  Files          28       28              
  Lines        1878     1880       +2     
==========================================
+ Hits         1650     1652       +2     
  Misses        228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@N5N3
Copy link
Contributor Author

N5N3 commented Oct 30, 2023

Looks like JLArray tests failed on master due to JuliaLang/julia#51764.
We can do nothing here. JLArrays.jl needs a patch like

Base.cconvert(::Type{Ptr{T}}, x::JLArray{T}) where {T} = Base.cconvert(Ptr{T}, x.data)

CC @@maleadt

@maleadt
Copy link
Member

maleadt commented Oct 31, 2023

JuliaGPU/GPUArrays.jl#500, JuliaRegistries/General#94501

@N5N3 N5N3 closed this Oct 31, 2023
@N5N3 N5N3 reopened this Oct 31, 2023
@N5N3
Copy link
Contributor Author

N5N3 commented Nov 20, 2023

bump

@mkitti
Copy link
Collaborator

mkitti commented Nov 20, 2023

Are we dropping Julia pre-1.6 compatability?

ChainRulesCore: Error During Test at D:\a\Interpolations.jl\Interpolations.jl\test\chainrules.jl:12
  Test threw exception
  Expression: Zygote.gradient(itp, 1) == Tuple(Interpolations.gradient(itp, 1))
  MethodError: no method matching _methods_by_ftype(::Type{Tuple{typeof(rrule),Zygote.ZygoteRuleConfig{Zygote.Context},Interpolations.BSplineInterpolation{Float64,1,Array{Float64,1},BSpline{Linear{Throw{OnGrid}}},Tuple{Base.OneTo{Int64}}},Int64}}, ::Int64, ::UInt64, ::Bool, ::Base.RefValue{UInt64}, ::Base.RefValue{UInt64}, ::Ptr{Int32})
  Closest candidates are:
    _methods_by_ftype(::Any, ::Int64, ::UInt64) at reflection.jl:835
    _methods_by_ftype(::Any, ::Int64, ::UInt64, !Matched::Array{UInt64,1}, !Matched::Array{UInt64,1}) at reflection.jl:838

@mkitti
Copy link
Collaborator

mkitti commented Nov 20, 2023

If we are, please adjust the CI here to drop 1.3.

@N5N3
Copy link
Contributor Author

N5N3 commented Nov 21, 2023

No idea here. I'm not familiar with CI setting. And the error has been there on master branch for quite a while.

@mkitti
Copy link
Collaborator

mkitti commented Nov 21, 2023

Remove this line:

@mkitti
Copy link
Collaborator

mkitti commented Nov 21, 2023

Change this line to Julia 1.6

julia = "1.3"

@mkitti mkitti merged commit 43fe00f into JuliaMath:master Nov 21, 2023
13 checks passed
@N5N3 N5N3 deleted the cbfix branch November 21, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoundsError with Julia 1.10.0-beta1
3 participants