-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkbounds
for trailing/missing dimensions.
#566
Conversation
023f184
to
1d00d5e
Compare
Why is CI stalled? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 87.85% 87.87% +0.01%
==========================================
Files 28 28
Lines 1878 1880 +2
==========================================
+ Hits 1650 1652 +2
Misses 228 228 ☔ View full report in Codecov by Sentry. |
Looks like Base.cconvert(::Type{Ptr{T}}, x::JLArray{T}) where {T} = Base.cconvert(Ptr{T}, x.data) CC @@maleadt |
bump |
Are we dropping Julia pre-1.6 compatability?
|
If we are, please adjust the CI here to drop 1.3. |
No idea here. I'm not familiar with CI setting. And the error has been there on master branch for quite a while. |
Remove this line:
|
Change this line to Julia 1.6 Interpolations.jl/Project.toml Line 35 in 4b617f6
|
close #562.