Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvnormal testvalue #207

Merged
merged 11 commits into from
Jun 9, 2022
Merged

Mvnormal testvalue #207

merged 11 commits into from
Jun 9, 2022

Conversation

cscherrer
Copy link
Collaborator

Fixes #206

Note that this depends on JuliaMath/MeasureBase.jl#60, which must be merged and released first.

@cscherrer cscherrer requested a review from mschauer June 8, 2022 14:35
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Package name latest stable
Mitosis.jl
Soss.jl

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #207 (6b1bafe) into master (7f028e7) will decrease coverage by 0.44%.
The diff coverage is 34.69%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   44.98%   44.53%   -0.45%     
==========================================
  Files          42       42              
  Lines        1236     1282      +46     
==========================================
+ Hits          556      571      +15     
- Misses        680      711      +31     
Impacted Files Coverage Δ
src/parameterized/mvnormal.jl 27.27% <20.00%> (-72.73%) ⬇️
src/utils.jl 48.52% <50.00%> (+0.19%) ⬆️
src/combinators/affine.jl 52.79% <63.63%> (+1.47%) ⬆️
src/combinators/transforms.jl 47.36% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f028e7...6b1bafe. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Package name latest stable
Mitosis.jl
Soss.jl

Copy link
Member

@mschauer mschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the first step needed

@cscherrer
Copy link
Collaborator Author

Thanks @mschauer . I'm going to add a few more tests, then merge and tag a release once those are passing

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer cscherrer merged commit ee201c9 into master Jun 9, 2022
@cscherrer cscherrer deleted the mvnormal-testvalue branch June 9, 2022 14:52
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Package name latest stable
Mitosis.jl
Soss.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testvalue(::MvNormal) fails
2 participants