Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorization depwarns accidentally export functions #37

Closed
carlobaldassi opened this issue Jul 27, 2017 · 3 comments
Closed

Vectorization depwarns accidentally export functions #37

carlobaldassi opened this issue Jul 27, 2017 · 3 comments

Comments

@carlobaldassi
Copy link

Despite the check of the julia version on the export statement in SpecialFunctions.jl, the vectorization deprecation warnings still export some functions.

Example: on julia 0.5:

julia-0.5> using SpecialFunctions

julia-0.5> erf
WARNING: both SpecialFunctions and Base export "erf"; uses of it in module Main must be qualified
ERROR: UndefVarError: erf not defined

Of course, this breaks compatibility in code that is supposed to work on julia 0.5 and later.

@carlobaldassi
Copy link
Author

Just for completeness, a solution for now is a very ugly conditional import:

VERSION >= v"0.6.0-dev.2767" && using SpecialFunctions

@ararslan
Copy link
Member

Can we just delete the deprecations at this point and assume that people will use dot-broadcast for vectorization? I'd be willing to bet that people are already familiar with doing that anyway.

@devmotion
Copy link
Member

The deprecations were removed in #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants