Bump Julia to 0.6, fix 0.7 depwarns, remove some deprecations #39
Conversation
ararslan
force-pushed
the
aa/deprecations
branch
from
bd8e9ba
to
37d427e
Compare
src/gamma.jl
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| using Base.MPFR: ROUNDING_MODE, big_ln2 | |||
|
|
|||
| @compat ComplexOrReal{T} = Union{T,Complex{T}} | |||
| ComplexOrReal{T} = Union{T,Complex{T}} | |||
There was a problem hiding this comment.
even though not necessary maybe add a const to make it evident it's a type alias?
src/deprecated.jl
Outdated
| @@ -1,28 +1,10 @@ | |||
| # This file contains code that was formerly a part of Julia. License is MIT: http://julialang.org/license | |||
|
|
|||
| using Base: @deprecate, depwarn | |||
There was a problem hiding this comment.
@deprecate is already exported by base
src/deprecated.jl
Outdated
| for f in (:polygamma, :zeta, :besseli, :besselix, :besselj, :besseljx, :besselk, :besselkx, | ||
| :bessely, :besselyx, :besselh, :besselhx, :hankelh1, :hankelh2, :hankelh1x, :hankelh2x) | ||
| @eval @dep_vectorize_2arg Number $f | ||
| end | ||
|
|
||
| @deprecate airy(z::Number) airyai(z) |
There was a problem hiding this comment.
presumably these were introduced in the last release, and hence require on more version bump before removal?
There was a problem hiding this comment.
? Those functions aren't being removed, just their implicit vectorizations
There was a problem hiding this comment.
L20 @deprecate airy(z::Number) airyai(z), not the line above that you removed .
I was wondering if these deprecations have been here for long enough to remove in this release as well?
There was a problem hiding this comment.
Oh I see. Yeah we could actually probably just delete everything in src/deprecated.jl at this point but I figured this was likely more commonly used in the wild than implicit vectorization, so I just left it for now.
ararslan
force-pushed
the
aa/deprecations
branch
from
37d427e
to
542bd87
Compare
|
May want to actually make use of the new DomainError feature? Maybe Compat could support 1 and 2-arg DomainError constructors that ignore the inputs. Hopefully that wouldn't have a performance cost on 0.6 and earlier. |
|
I agree that it would be good to make use of that feature but that was a bigger change than I wanted to do here. |
|
Now that |
Summary of changes:
DomainErrordeprecation on 0.7