-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
associatedLegendre.jl #24
Open
elaineVRC
wants to merge
7
commits into
JuliaMath:master
Choose a base branch
from
elaineVRC:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 27, 2017
-
Matlab doesn't calculate associated Legendre type 3 (z>1) function but does do type 2 (-1<=x<=1) approx. .0007 sec compared to average .00014sec recNM3(n,m,z) which is a recursive implementation.
Configuration menu - View commit details
-
Copy full SHA for 9e3a88c - Browse repository at this point
Copy the full SHA 9e3a88cView commit details
Commits on Mar 8, 2017
-
Julia file that calculates some associated Legendre functions
Configuration menu - View commit details
-
Copy full SHA for 390ab12 - Browse repository at this point
Copy the full SHA 390ab12View commit details
Commits on Apr 1, 2017
-
On line 46 changed 1 to one(x) On line 84 changed 1. to one(z) for arbitrary precision, etc.
Configuration menu - View commit details
-
Copy full SHA for 5c80503 - Browse repository at this point
Copy the full SHA 5c80503View commit details
Commits on May 23, 2017
-
Thanks for editting and making the PR more readable; congratulations on your new position AA. Thanks to SJ for mentoring and encouragement. I can't benchmark against what does not exist: matlab, maxima, scipy.special, gsl do not have associated Legendre type 3 (z > 1). I have used SLegendreP3 (which I derived and used a long time ago) ; similarly SLegendreP2 gives reliable results compared to scipy.special for |x| <1 . function BenchmarkZZLegendreP2 , shows that ZZLegendreP2 is faster than scipy.special. ZZLegendreP3 comes from a modification of work published by Selezneva, etal. If the general direction of the PR is OK; then I can extract all the test... functions to test.jl and do additional work. All suggestions, comments,etc. are welcome. Thank you for helping me to learn Julia scientific computing.
Configuration menu - View commit details
-
Copy full SHA for 82a1469 - Browse repository at this point
Copy the full SHA 82a1469View commit details
Commits on Aug 18, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f41bf17 - Browse repository at this point
Copy the full SHA f41bf17View commit details
Commits on Aug 25, 2017
-
This PR is the file entitled associatedLegendre.jl. The first part with all the comments is like a readme. The rest is the source code and numerous tests(requested) and exploration of area near |x| ~ 1. As requested @Btime from BenchmarkTools as well as @time gave similar results in that ZZLegendreP2 is light years ahead of scipy.special.lpmv. Accuracy of ZZLegendreP2 (|z|=<1.) against lpmv and ZZLegendreP3 (z>1.) against Fortran is good.
Configuration menu - View commit details
-
Copy full SHA for 8362ec8 - Browse repository at this point
Copy the full SHA 8362ec8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d485f - Browse repository at this point
Copy the full SHA 10d485fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.