Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zeta sign flipping in some input regions (#420) #422

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

quytelda
Copy link
Contributor

As described in issue #420, zeta(s) actually returns $-\zeta(s)$ for some input regions. This patch fixes the issue and adds a few corresponding tests.

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Base: 91.87% // Head: 93.46% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (b8ec371) compared to base (2cbb4ae).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   91.87%   93.46%   +1.58%     
==========================================
  Files          14       14              
  Lines        2967     2908      -59     
==========================================
- Hits         2726     2718       -8     
+ Misses        241      190      -51     
Flag Coverage Δ
unittests 93.46% <ø> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/gamma.jl 94.52% <ø> (ø)
src/beta_inc.jl 91.16% <0.00%> (-1.20%) ⬇️
src/gamma_inc.jl 93.46% <0.00%> (+1.84%) ⬆️
src/expint.jl 94.34% <0.00%> (+5.04%) ⬆️
src/erf.jl 100.00% <0.00%> (+5.84%) ⬆️
src/sincosint.jl 100.00% <0.00%> (+34.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevengj stevengj merged commit 5d33031 into JuliaMath:master Jan 2, 2023
stevengj pushed a commit that referenced this pull request Jan 3, 2023
* Small bug on gamma_inc_temme_1 fixed (#419)

* Fix zeta sign flipping in some input regions (#420) (#422)

Co-authored-by: Marco Lombardi <marco.lombardi@gmail.com>
Co-authored-by: Quytelda Kahja <quytelda@tamalin.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants