Hopefully fix 0.5 builds by swapping out deprecated things #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh nice, now all checks fail. ಠ_ಠ |
|
I guess that explains why the test file wasn't doing |
|
I changed the tests to specifically use Edit: It appears to be helping. As of this writing, the Linux 0.4 and nightly tests pass! 🎉 |
|
The failure on Win32 is just a timeout. Looks like tests work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FloatingPointis deprecated in 0.4 and has since been removed, which is causing the failures on the nightlies. I swapped that out forAbstractFloat. I similarly swappedsymbolforSymbolto remove the deprecation warnings. The format of runtests.jl was kind of weird so I updated it to use the more standard (AFAIK) format. While I was at it, I also removed trailing whitespace. Now let's see what happens...