Replace @timing_seq by thread-local timers
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool! But you removed a bunch (sternheimer and ffts) that seem useful? |
|
well yes, but the _seq stuff was disabled by default and has always been a bit tricky to enable (clean precompile cache, set environment variable, disable threadying, etc.). So I honestly never used it. Did you? I think it's better to track these things by appropriate thread-local timers and timers in surrounding sections now. Regarding the Sternheimer, yes that we could annotate better, but as it stands the timer has been disabled the whole time (it was a |
|
OK ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.