Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in add default options #1043

Merged
merged 1 commit into from Jun 12, 2023
Merged

Fix bug in add default options #1043

merged 1 commit into from Jun 12, 2023

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Jun 12, 2023

Fixes #1038 and #1041

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1043 (fe2fa7d) into master (1fc8255) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head fe2fa7d differs from pull request most recent head 4e60e2c. Consider uploading reports for the commit 4e60e2c to get more accurate results

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
- Coverage   85.35%   85.32%   -0.04%     
==========================================
  Files          43       43              
  Lines        3202     3202              
==========================================
- Hits         2733     2732       -1     
- Misses        469      470       +1     
Impacted Files Coverage Δ
src/multivariate/optimize/interface.jl 83.96% <100.00%> (+1.88%) ⬆️

... and 1 file with indirect coverage changes

@pkofod pkofod merged commit 1f79069 into master Jun 12, 2023
13 of 14 checks passed
@pkofod pkofod deleted the pkm/namedupltesoops branch June 12, 2023 19:31
@blegat blegat mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

patch 1.7.4 -> 1.7.5 breaks Accelerated/MomentumGradientDescent()
1 participant