Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and reorganize README.md #1076

Merged
merged 2 commits into from Feb 5, 2024
Merged

Update and reorganize README.md #1076

merged 2 commits into from Feb 5, 2024

Conversation

odow
Copy link
Contributor

@odow odow commented Feb 3, 2024

x-ref jump-dev/JuMP.jl#3624

I've made quite a few changes, so it's probably best viewed https://github.com/odow/Optim.jl/blob/patch-1/README.md

Main changes are:

  • Remove table of badges
  • Use explicit Markdown links
  • Remove mathematical description of rosebbrock
  • Remove suggestion to tag @pfkod explicitly
  • Fix JuMP example, which @blegat got wrong 😆 (missing objective sense)

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca3513f) 84.97% compared to head (c2f7cd6) 84.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   84.97%   84.85%   -0.12%     
==========================================
  Files          46       46              
  Lines        3480     3480              
==========================================
- Hits         2957     2953       -4     
- Misses        523      527       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Contributor Author

odow commented Feb 3, 2024

README.md Outdated Show resolved Hide resolved
@pkofod
Copy link
Member

pkofod commented Feb 5, 2024

Looks good. I did suggest a change, because the slack channel name has math- first

Co-authored-by: Patrick Kofod Mogensen <patrick.mogensen@gmail.com>
@odow
Copy link
Contributor Author

odow commented Feb 5, 2024

Done.

@pkofod pkofod merged commit 3af51c8 into JuliaNLSolvers:master Feb 5, 2024
8 of 9 checks passed
@pkofod
Copy link
Member

pkofod commented Feb 5, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants