Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Add OptimizeNotCalled error #1766

Merged
merged 2 commits into from
Jan 11, 2019
Merged

🚸 Add OptimizeNotCalled error #1766

merged 2 commits into from
Jan 11, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 10, 2019

It should resolve the issue of #1739 (comment)

@mlubin
Copy link
Member

mlubin commented Jan 11, 2019

This looks reasonable. Note the doctest failures.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #1766 into master will increase coverage by 0.05%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
+ Coverage   69.09%   69.14%   +0.05%     
==========================================
  Files          30       30              
  Lines        3944     3957      +13     
==========================================
+ Hits         2725     2736      +11     
- Misses       1219     1221       +2
Impacted Files Coverage Δ
src/JuMP.jl 71.9% <81.25%> (+0.6%) ⬆️
src/objective.jl 95% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798258d...e5aa164. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #1766 into master will increase coverage by 0.3%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1766     +/-   ##
=========================================
+ Coverage   69.09%   69.39%   +0.3%     
=========================================
  Files          30       30             
  Lines        3944     4013     +69     
=========================================
+ Hits         2725     2785     +60     
- Misses       1219     1228      +9
Impacted Files Coverage Δ
src/JuMP.jl 71.9% <81.25%> (+0.6%) ⬆️
src/objective.jl 95% <0%> (+5%) ⬆️
src/constraints.jl 79.19% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798258d...e5aa164. Read the comment docs.

@blegat blegat merged commit e9346a0 into master Jan 11, 2019
@odow odow deleted the bl/optimizenotcalled branch January 27, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants