Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document storage of constraints #569

Merged
merged 2 commits into from Nov 13, 2018
Merged

Document storage of constraints #569

merged 2 commits into from Nov 13, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Nov 12, 2018

This is a first step to help readability of this file.

@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #569 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   95.67%   95.79%   +0.12%     
==========================================
  Files          47       47              
  Lines        4834     4976     +142     
==========================================
+ Hits         4625     4767     +142     
  Misses        209      209
Impacted Files Coverage Δ
src/Utilities/model.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfce251...a77213c. Read the comment docs.

@@ -1,3 +1,19 @@
## Storage of constraints
#
# All `F`-in-`S` constraints are stored in a vector of `C{F, S}`. The index in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C isn't a very readable name, any possible improvements?

@blegat blegat merged commit 81c1155 into master Nov 13, 2018
@odow odow deleted the bl/doc_con_storage branch March 6, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants