Merge pull request #46 from JuliaOpt/od/empty_sums

Fix empty sums test
jump-dev · Apr 4, 2020 · 407a8fd · 407a8fd · blegat · Apr 5, 2020
2 parents da1a437 + 2096349
commit 407a8fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,14 +1,15 @@
 name = "MutableArithmetics"
 uuid = "d8a4904e-b15c-11e9-3269-09a3773c0cb0"
 authors = ["Gilles Peiffer", "Benoît Legat", "Sascha Timme"]
-version = "0.2.8"
+version = "0.2.9"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
+OffsetArrays = "1"
 julia = "1"
 
 [extras]

diff --git a/src/Test/scalar.jl b/src/Test/scalar.jl
@@ -32,13 +32,13 @@ function empty_sum_test(x)
     #@test MA.isequal_canonical(MA.@rewrite(x .+ sum(1 for i in 1:0) * sum(x for i in 1:0)), x)
     #@test MA.isequal_canonical(MA.@rewrite(x .+ 1^2 * sum(1 for i in 1:0) * sum(x for i in 1:0) * 1^2), x)
     @test MA.isequal_canonical(MA.@rewrite(x .+ sum(1 for i in 1:0)), x)
-    @test MA.isequal_canonical(MA.@rewrite(x .+ sum(1 for i in 1:0)) * 1^2, x)
-    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0)) .+ x, x)
-    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0)) * 1^2 .+ x, x)
+    @test_broken MA.isequal_canonical(MA.@rewrite(x .+ sum(1 for i in 1:0) * 1^2), x + 0)
+    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0) .+ x), x)
+    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0) * 1^2 .+ x), x)
     @test MA.isequal_canonical(MA.@rewrite(x .- sum(1 for i in 1:0)), x)
-    @test MA.isequal_canonical(MA.@rewrite(x .- sum(1 for i in 1:0)) * 1^2, x)
-    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0)) .- x, -x)
-    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0)) * 1^2 .- x, -x)
+    @test_broken MA.isequal_canonical(MA.@rewrite(x .- sum(1 for i in 1:0) * 1^2), x)
+    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0) .- x), -x)
+    @test MA.isequal_canonical(MA.@rewrite(sum(1 for i in 1:0) * 1^2 .- x), -x)
 end
 
 function cube_test(x)