Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty sums test #46

Merged
merged 3 commits into from
Apr 4, 2020
Merged

Fix empty sums test #46

merged 3 commits into from
Apr 4, 2020

Conversation

odow
Copy link
Member

@odow odow commented Apr 3, 2020

@blegat: I screwed up and put some parentheses in the wrong place.

I'm not sure how to intercept the sum(1 for _ in 1:0) in a broadcast and re-write as a for-loop. Might need your help on this one.

@odow odow requested a review from blegat April 3, 2020 19:30
@odow
Copy link
Member Author

odow commented Apr 3, 2020

@blegat please double check this, merge, and then tag when you wake up :)

@odow odow mentioned this pull request Apr 3, 2020
Merged
@blegat blegat merged commit 407a8fd into master Apr 4, 2020
@odow odow deleted the od/empty_sums branch June 18, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat Awaiting requested review from blegat

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odow @blegat