Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quad gpu fix #121

Merged
merged 9 commits into from
Aug 29, 2021
Merged

Quad gpu fix #121

merged 9 commits into from
Aug 29, 2021

Conversation

zsteve
Copy link
Member

@zsteve zsteve commented Aug 27, 2021

This PR fixes type issues that prevent quadreg from running with CuArrays, and adds a test for that setting.
Also fixes a bug with the Armijo step search which I found for certain inputs caused the solver to get stuck.

@coveralls
Copy link

coveralls commented Aug 27, 2021

Pull Request Test Coverage Report for Build 1176317897

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.671%

Totals Coverage Status
Change from base Build 1174249145: 0.02%
Covered Lines: 671
Relevant Lines: 687

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #121 (22b4f92) into master (d33f1cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   97.65%   97.67%   +0.01%     
==========================================
  Files          13       13              
  Lines         682      687       +5     
==========================================
+ Hits          666      671       +5     
  Misses         16       16              
Impacted Files Coverage Δ
src/quadratic_newton.jl 98.16% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33f1cf...22b4f92. Read the comment docs.

@zsteve zsteve requested a review from devmotion August 28, 2021 03:07
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zsteve zsteve merged commit d005664 into master Aug 29, 2021
@zsteve zsteve deleted the quad_gpu_fix branch August 29, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants