-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quad gpu fix #121
Quad gpu fix #121
Conversation
Pull Request Test Coverage Report for Build 1176317897
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 97.65% 97.67% +0.01%
==========================================
Files 13 13
Lines 682 687 +5
==========================================
+ Hits 666 671 +5
Misses 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR fixes type issues that prevent
quadreg
from running with CuArrays, and adds a test for that setting.Also fixes a bug with the Armijo step search which I found for certain inputs caused the solver to get stuck.