Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rand implementations provided by Distributions.jl v0.17 #15

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Use rand implementations provided by Distributions.jl v0.17 #15

merged 1 commit into from
Apr 6, 2019

Conversation

lassepe
Copy link
Member

@lassepe lassepe commented Apr 5, 2019

This fixes #13. As @MaximeBouton pointed out, we might want to tag a new version if you guys are happy with these changes.

@coveralls
Copy link

coveralls commented Apr 5, 2019 •
edited

Pull Request Test Coverage Report for Build 67

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 56.604%
Totals Coverage Status
Change from base Build 64: -0.4%
Covered Lines: 120
Relevant Lines: 212
💛 - Coveralls

lassepe added a commit to lassepe/POMDPModelTools.jl that referenced this pull request Apr 5, 2019
@lassepe
Use @test_logs to check for warnings
bf5eef3 
Stumbled across this when implementing JuliaPOMDP#15. Thus, I won't touch
`test_distributions_jl.jl` here.
@lassepe lassepe mentioned this pull request Apr 5, 2019
Merged
@lassepe lassepe requested a review from zsunberg April 5, 2019 07:51
@MaximeBouton
Copy link
Contributor

Looks good, I think we should:

  • tag POMDPModelTools v0.1.4 with Distributions < v0.17
  • merge
  • tag POMDPModelTools v0.1.5 with Distributions >= v0.17
    Does that sound correct?
    I believe we should do it before Monday when the package registration system will be migrate to Registrator.

zsunberg
zsunberg requested changes Apr 5, 2019
View reviewed changes
src/distributions/distributions_jl.jl Outdated Show resolved Hide resolved
@lassepe lassepe force-pushed the useDistributions017 branch 3 times, most recently from 39cacbb to 41556db Compare April 5, 2019 19:45
@lassepe
Make use of Distributions.jl v0.17
d144737 
- fixes JuliaPOMDP#13

Update tests

Add tests for Base.iterate(d::Categorical)

Remove `distributions_jl.jl`
@lassepe lassepe requested a review from zsunberg April 5, 2019 19:47
zsunberg
zsunberg approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@zsunberg zsunberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@zsunberg
Copy link
Member

zsunberg commented Apr 5, 2019

I am going to tag v0.1.4, merge this, and then tag v0.1.5

@zsunberg zsunberg merged commit b8d9fc5 into JuliaPOMDP:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsunberg zsunberg zsunberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make use of improvements in Distributions.jl v0.17.0
4 participants
@lassepe @coveralls @MaximeBouton @zsunberg