Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_parallel uses pmap and handle worker ids correctly #11

Merged
merged 8 commits into from Apr 3, 2019

Conversation

lassepe
Copy link
Member

@lassepe lassepe commented Mar 14, 2019

  • use progress_pmap from ProgressMeters.jl
  • introduc pool argument to specify the worker pool
  • fix the bug of wrong worker id's by iterating over pool instead of 1:nprocs() (not all ID's must be occupied, e.g. if workers were killed).
  • update warning to match the new behavior

@lassepe lassepe changed the title run_parallel uses pmap and handles worker ids correctly run_parallel uses pmap and handle worker ids correctly Mar 14, 2019
@coveralls
Copy link

coveralls commented Mar 14, 2019

Pull Request Test Coverage Report for Build 52

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 82.891%

Files with Coverage Reduction New Missed Lines %
src/stepthrough.jl 7 66.23%
Totals Coverage Status
Change from base Build 43: -1.0%
Covered Lines: 281
Relevant Lines: 339

💛 - Coveralls

@zsunberg
Copy link
Member

Looks good, except progress isn't actually fed into pmap_progress. After thinking about it last night, I actually like the idea of having progress and show_progress as separate arguments. Can you make the change to that?

Thanks! Thanks for writing good code

@lassepe
Copy link
Member Author

lassepe commented Mar 28, 2019

Looks good, except progress isn't actually fed into pmap_progress. After thinking about it last night, I actually like the idea of having progress and show_progress as separate arguments. Can you make the change to that?

Thanks! Thanks for writing good code

Okay, will do. Note, that implementing it with show_progress will change behavior. In the current master version, if one passes progress=nothing, no progress bar is shown. (this behavior is also used in the tests).

@zsunberg
Copy link
Member

Great, thanks @lassepe . I just added a deprecation warning for progress=nothing in case it is being used anywhere

@zsunberg
Copy link
Member

If the tests pass, it looks good to me

@zsunberg zsunberg merged commit e6eaef1 into JuliaPOMDP:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants