-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is POMDPs v0.9 lower bounded to Julia v1.1? #321
Comments
Did all the POMDPs.jl tests pass? At some point I used something that was not in 1.0, I think in @gen, but I may have removed it in some type of cleanup. |
If I recall correctly, Julia 1.0.3 type inference could not figure out the return type of |
That is true, but I am 90% sure that wasn't the reason that I did it. I
think there was something that just flat-out didn't work.
…On Thu, Oct 1, 2020 at 1:43 PM Lasse Peters ***@***.***> wrote:
If I recall correctly, Julia 1.0.3 type inference could not figure out the
return type of @gen which made it essentially unusable.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABALI2Y4QAFQHJUIKTUU733SITLVXANCNFSM4SAFRLQA>
.
|
@zsunberg I'd imagine that it was originally because the POMDPs registry doesn't work for 1.0. While If I ignore the |
Ah, yeah, I think it is because of those reasons. Would it be extremely helpful to you if we tagged POMDPs 0.9.2 that is compatible with Julia 1.0? It seems like anything built with Julia 1.0.3 would be compatible with POMDPs 0.8. |
That would be very helpful! |
Ritchie Lee is required to use Julia v1.0.3 for a project and wants to use POMDPStressTesting which requires the latest MCTS, yet POMDPs 0.9 is restricted to Julia 1.1 as a lower bound. If you "dev" POMDPs.jl you're able to bypass the Julia version requirement. I did that to test POMDPStressTesting and passed all of my tests.
I'm just curious what the rational was to add the Julia 1.1 bound.
The text was updated successfully, but these errors were encountered: