Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is POMDPs v0.9 lower bounded to Julia v1.1? #321

Closed
mossr opened this issue Oct 1, 2020 · 6 comments
Closed

Why is POMDPs v0.9 lower bounded to Julia v1.1? #321

mossr opened this issue Oct 1, 2020 · 6 comments

Comments

@mossr
Copy link
Member

mossr commented Oct 1, 2020

Ritchie Lee is required to use Julia v1.0.3 for a project and wants to use POMDPStressTesting which requires the latest MCTS, yet POMDPs 0.9 is restricted to Julia 1.1 as a lower bound. If you "dev" POMDPs.jl you're able to bypass the Julia version requirement. I did that to test POMDPStressTesting and passed all of my tests.

I'm just curious what the rational was to add the Julia 1.1 bound.

@zsunberg
Copy link
Member

zsunberg commented Oct 1, 2020

Did all the POMDPs.jl tests pass? At some point I used something that was not in 1.0, I think in @gen, but I may have removed it in some type of cleanup.

@lassepe
Copy link
Member

lassepe commented Oct 1, 2020

If I recall correctly, Julia 1.0.3 type inference could not figure out the return type of @gen which made it essentially unusable.

@zsunberg
Copy link
Member

zsunberg commented Oct 1, 2020 via email

@mossr
Copy link
Member Author

mossr commented Oct 2, 2020

@zsunberg I'd imagine that it was originally because the POMDPs registry doesn't work for 1.0. While @inferred fails because it thinks @gen always returns Any, I'm still able to use @gen as expected in Julia 1.0 without issues.

If I ignore the @inferred tests and wrap POMDPs.add_registry() with if VERSION ≥ v"1.1", all other tests pass.

@zsunberg
Copy link
Member

zsunberg commented Oct 3, 2020

Ah, yeah, I think it is because of those reasons. Would it be extremely helpful to you if we tagged POMDPs 0.9.2 that is compatible with Julia 1.0? It seems like anything built with Julia 1.0.3 would be compatible with POMDPs 0.8.

@mossr
Copy link
Member Author

mossr commented Oct 3, 2020

That would be very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants