Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@POMDP_require deprecation in POMDPTools #463

Closed
WhiffleFish opened this issue Feb 22, 2023 · 3 comments
Closed

@POMDP_require deprecation in POMDPTools #463

WhiffleFish opened this issue Feb 22, 2023 · 3 comments

Comments

@WhiffleFish
Copy link
Member 

julia> using POMDPTools
[ Info: Precompiling POMDPTools [7588e00f-9cae-40de-98dc-e0c70c48cdd7]
┌ Warning: POMDPs.@POMDP_require is deprecated, use POMDPLinter.@POMDP_require instead.
└ @ POMDPs ~/code/random/POMDPs.jl/src/deprecated.jl:18
@zsunberg
Copy link
Member

Yeah, this is super annoying. I do not know how to track it down though, ha. I guess we need to register POMDPs.jl 1.0 and remove POMDPs.@POMDP_require fully.

@zsunberg zsunberg reopened this Feb 22, 2023
@WhiffleFish
Copy link
Member Author

Is there anything stopping us from releasing a POMDPs.jl v0.10?

Anyways, it appears that changing @POMDP_require calls to explicit POMDPLinter.@POMDP_require calls fixes the issue.

If we're willing to admit this temporary workaround I can open a PR. If not, semver would suggest that moving from 0.9 to 0.10 would admit breaking changes. So technically it would be fine to remove POMDPs.@POMDP_require along with POMDPs.@req, POMDPs.@subreq, etc. in that version bump, no?

@WhiffleFish
Copy link
Member Author

fixed by #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zsunberg @WhiffleFish