Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecations #466

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Remove Deprecations #466

merged 1 commit into from
Mar 10, 2023

Conversation

WhiffleFish
Copy link
Member

No description provided.

@WhiffleFish
Copy link
Member Author

WhiffleFish commented Mar 10, 2023

How do we usually handle this? The current registered POMDPTools version assumes that POMDPs exports all of the POMDPLinter stuff.

So, updating POMDPs breaks POMDPTools in docs and updating POMDPTools breaks the POMDPTools CI as it depends on the current registered version of POMDPs.

Instead of building docs on the current registered version of POMDPTools, do we add it by relative path in docs/make.jl?

Furthermore, the docs depend on POMDPModels.jl which ALSO uses a bunch of deprecated functionality that would be removed.

@zsunberg
Copy link
Member

How do we usually handle this?

Just register it without the docs building, then get all the code working correctly, and then create a v1.0.0+docs tag so that the documentation builds and the stable documentation link works.

@zsunberg zsunberg merged commit 6e1ce99 into JuliaPOMDP:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants