Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not actually testing on MacOS/Windows #481

Closed
WhiffleFish opened this issue Apr 27, 2023 · 4 comments
Closed

Not actually testing on MacOS/Windows #481

WhiffleFish opened this issue Apr 27, 2023 · 4 comments

Comments

@WhiffleFish
Copy link
Member

All CI badges point to the same link.

We're only actually testing on ubuntu-latest as made evident in CI.yml.

@zsunberg
Copy link
Member

My bad

image

@zsunberg
Copy link
Member

We should definitely not lie on the README, but there are two solutions:

  1. actually test on all OSs
  2. just have one badge

I don't think there is any OS-specific code, so maybe we would be better citizens with solution (2) not taking up the resources. Also, at least in the olden days, testing on Windows and Mac was super annoying because it would take a long time for a machine to become available. On the other hand, people might be more confident in using it if they see that their OS has a green box next to it (though if they know what the green box means, they probably realize that it doesn't matter).

@rejuvyesh
Copy link
Member

I think it's easy enough to test on multiple os with: runs-on: ${{ matrix.os }} and setting up the matrix.os appropriately. IMO we should test on the major 3 OS.

@zsunberg
Copy link
Member

This was fixed with #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants