-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring MacOS/Windows back into CI #486
Conversation
*sigh* now we have to make all of our gh actions scripts windows-proof. Yet another man-hour of humanity's time that Microsoft has wasted. |
@WhiffleFish this is amazing. Can you add a comment to the yml file explaining that the conversion of symbols to strings is to maintain OS compatibility? |
I understand why we need |
Maybe because it is in a quoted shell command? |
I assume that it has to do with the way windows handles various quotes, so you can't use the trick where ' are used to create arguments with " in them. Thus, we have to avoid using " anywhere in the command. @WhiffleFish is this correct? Can you add the comment requested above so that I can merge this? |
Yep, that is entirely correct. I figured there'd be a way to escape the quotes ( |
@WhiffleFish thanks! It seems like there should be a recommended way that is more straightforward, but this is great for now. |
* Bring MacOS/Windows back into CI * horrendous os-agnostic ci script * ci string compatibility workaround comment
No description provided.