Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MEMFS on all platforms so the library isn't looking for /works… #1120

Closed
wants to merge 1 commit into from

Conversation

weech
Copy link
Contributor

@weech weech commented Jun 5, 2020

…pace/destdir/... files

@weech
Copy link
Contributor Author

weech commented Jun 5, 2020

I tested it on x86_64-linux-gnu by linking it to GRIB.jl and running the test suite with it (passing), vs linking GRIB.jl to the artifact in last night's jll (failing due to the absolute path issue). I don't know how well the memory-mapped version works on other platforms though. The other possibility is to have the jll set an environment variable that overrides where the library looks for the definition and sample files.

@giordano
Copy link
Member

giordano commented Jun 5, 2020

The other possibility is to have the jll set an environment variable that overrides where the library looks for the definition and sample files.

We currently don't have a good mechanism to do this, even though it's desirable: JuliaPackaging/BinaryBuilder.jl#687. Anyway you can set such environment variable at init time in your package, see the examples in the issue mentioned.

@weech
Copy link
Contributor Author

weech commented Jun 5, 2020

I tried it out using the example from GTK.jl and it works to just set the environment variables in GRIB.jl's __init__, so this change isn't necessary. Setting the environment variables is probably required for eventual Windows support anyways, so we'll stick with that solution.

@weech weech closed this Jun 5, 2020
@weech weech deleted the eccodes_patch_2.17 branch June 5, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants