Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard recipe: UDUNITS-v2.2.28 #4232

Merged

Conversation

simonbyrne
Copy link
Contributor

This pull request contains a new build recipe I built using the BinaryBuilder.jl wizard:

  • Package name: UDUNITS
  • Version: v2.2.28

@staticfloat please review and merge.

@simonbyrne
Copy link
Contributor Author

I'm not sure about the naming here (in particular the capitalization):
https://www.unidata.ucar.edu/software/udunits/udunits-2.2.28/udunits2.html

cc: @jakebolewski

@giordano
Copy link
Member

I think you're seeing #3949 and you have to manually set

export CPPFLAGS="-I${includedir}"

before running configure

@giordano
Copy link
Member

Capitalization of the name is fine

@giordano
Copy link
Member

My educated guess for powerpc is https://docs.binarybuilder.org/stable/troubleshooting/#Shared-library-not-built, I don't know what's up with freebsd though

@simonbyrne
Copy link
Contributor Author

@simonbyrne
Copy link
Contributor Author

Also not sure what the issue with PPC is (it looks like it isn't building a shared library?). @vchuravy any ideas?

@giordano
Copy link
Member

The __FreeBSD__ macro should be defined on freebsd

@jakebolewski
Copy link
Contributor

@giordano any suggestions on what to do about: https://github.com/Unidata/UDUNITS-2/blob/c83da987387db1174cd2266b73dd5dd556f4476b/lib/xml.c#L2140 on BSD?

I would try if not defined WIN32 for that pre-processor branch

@simonbyrne simonbyrne force-pushed the wizard/UDUNITS-v2.2.28_12d96fc1 branch 5 times, most recently from a2f8d38 to 59a0cef Compare January 12, 2022 02:48
@simonbyrne
Copy link
Contributor Author

Okay, now I'm stuck. All the builds are failing with:

[01:06:40] WARNING: 'makeinfo' is missing on your system.
[01:06:40]          You should only need it if you modified a '.texi' file, or
[01:06:40]          any other file indirectly affecting the aspect of the manual.
[01:06:40]          You might want to install the Texinfo package:
[01:06:40]          <http://www.gnu.org/software/texinfo/>
[01:06:40]          The spurious makeinfo call might also be the consequence of
[01:06:40]          using a buggy 'make' (AIX, DU, IRIX), in which case you might
[01:06:40]          want to install GNU make:
[01:06:40]          <http://www.gnu.org/software/make/>

@jakebolewski
Copy link
Contributor

Install the texinfo alpine pkg? I would imagine there is a flag for disabling the doc building

@simonbyrne
Copy link
Contributor Author

What's weird is that it only appeared after running autoreconf.

@simonbyrne simonbyrne force-pushed the wizard/UDUNITS-v2.2.28_12d96fc1 branch from b72b670 to 7662f80 Compare January 12, 2022 05:32
@simonbyrne
Copy link
Contributor Author

Okay switching to cmake fixed it.

* We don't need to explicitly use `experimental=true` anymore
* Add compat bound for `Expat_jll` for good measure
@giordano
Copy link
Member

CMake to the rescue, who'd have thought that? 😏

@giordano giordano enabled auto-merge (squash) January 12, 2022 11:02
@giordano giordano merged commit 73d08b2 into JuliaPackaging:master Jan 12, 2022
@simonbyrne simonbyrne deleted the wizard/UDUNITS-v2.2.28_12d96fc1 branch January 12, 2022 16:37
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
* New Recipe: UDUNITS v2.2.28

* try building all platforms

* Update build_tarballs.jl

* Update build_tarballs.jl

* FreeBSD patch

* dont make all

* try cmake again

* try cmake again

* upgrade CMake, use FreeBSD patch from upstream

* try experimental

* [UDUNITS] Min changes

* We don't need to explicitly use `experimental=true` anymore
* Add compat bound for `Expat_jll` for good measure

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants