Polish up docstrings and more #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to follow the general tips at https://docs.julialang.org/en/latest/manual/documentation/
This makes it a bit easier to read the code in my opinion.
Since F could be anything, it was not restricted to functions, even though this was probably the intention.
jpsamaroo
approved these changes
Feb 16, 2020
|
Thanks for having a look! I addressed the comments. |
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if this is too much of a mixed bag, would be happy to split it up as well. But it's mostly straightforward.
88d9964 removes empty files
d6aca84 only touches docstrings
4cd0051 adds argument type annotations, good to double check if all are correct
82c1506 is a simple do block
a4c409b DArray.concat must be a function right?
d8f4fde looks like an oversight