BlockIO: fix find_end_pos/find_start_pos in constructor #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iblis17 , can you recall what this PR is intended to fix/improve? Do you have an MWE that this fixes? |
|
Hi @jpsamaroo , there are two commits in this PR. |
|
I see... if you happen to have some example code that we can use to benchmark this change, that'd be awesome. I don't know enough about the BlockIO code to be able to guess what impact this change could have. |
|
well, no benchmark snippets on hand... too long ago. |
|
We are probably going to remove the io stuff from this package and start recommending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.