avoid stackoverflow in deserialize #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding deserialization of DArray introduced in #80 cause the below error: ``` xret = CapturedException(StackOverflowError(), Any[(deserialize(::SerializationState{IOStream}, ::Type{Dagger.DArray{Any,2,Base.#cat}}) at darray.jl:117, 100)]) DArray constructor: Error During Test Got an exception of type StackOverflowError outside of a @test StackOverflowError: Stacktrace: [1] deserialize(::SerializationState{IOStream}, ::Type{Dagger.DArray{Any,2,Base.#cat}}) at /home/tan/.julia/v0.6/Dagger/src/array/darray.jl:117 (repeats 20000 times) ``` Strangely the tests had passed then. This is to avoid the stack overflow error. I did not find any other mechanism to invoke a specific method instance. Also included a change in tests to have it pass when `Dagger.use_shared_array[] == false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding deserialization of DArray introduced in #80 cause the below error:
Strangely the tests had passed then.
This is to avoid the stack overflow error. I did not find any other mechanism to invoke a specific method instance.
Also included a change in tests to have it pass when
Dagger.use_shared_array[] == false.