Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define one(::Type{Measurement{T}}) to return one(T) #135

Merged
merged 6 commits into from
Mar 22, 2023
Merged

Conversation

giordano
Copy link
Member

This will eventually fix #134, but there are lots of failures.

CC: @stevengj. I opened the PR for reference, but I don't really know what to do with all the failures.

@giordano
Copy link
Member Author

Ok, all in all the problems here are inference issue of complex power and det (#134 (comment)), which I believe are bugs in Julia itself, not this package. In #134 I mentioned a spate of issues in QuadGK.jl, but those are unrelated to this PR and this package.

test/runtests.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #135 (ea728cf) into master (4ffcdbf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ea728cf differs from pull request most recent head 02195b2. Consider uploading reports for the commit 02195b2 to get more accurate results

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   95.44%   95.45%   +0.01%     
==========================================
  Files          13       12       -1     
  Lines         746      726      -20     
==========================================
- Hits          712      693      -19     
+ Misses         34       33       -1     
Impacted Files Coverage Δ
src/Measurements.jl 86.66% <ø> (-0.44%) ⬇️
src/math.jl 97.93% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giordano giordano marked this pull request as ready for review March 22, 2023 15:45
@giordano
Copy link
Member Author

I have no idea of why the benchmarks are broken, but this happens always whenever you touch anything related to the benchmarks. It's really cumbersome to use PkgBenchmark when you make any changes to the package, which kinda defeats the purpose of running it in PRs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

one(measurement) should return 1, not 1 ± 0
3 participants