Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt 2: Implement BaseType extension #156

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

MilesCranmer
Copy link
Member

Another try at #155, this time as an extension.

cc @stevengj

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #156 (1fde506) into master (21cf93c) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 1fde506 differs from pull request most recent head b45023c. Consider uploading reports for the commit b45023c to get more accurate results

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   96.76%   96.60%   -0.16%     
==========================================
  Files           9        9              
  Lines         618      619       +1     
==========================================
  Hits          598      598              
- Misses         20       21       +1     
Files Coverage Δ
src/Measurements.jl 75.00% <100.00%> (-2.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giordano
Copy link
Member

Ok, let's do this, thanks!

@giordano giordano merged commit e3cb224 into JuliaPhysics:master Oct 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants