Switch to Project.toml, cap Documenter #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a Project.toml, instead of a mix of REQUIRE + Pkg.add commands to define the environment for the doc build. Also, cap Documenter to 0.19 due to upcoming breaking changes https://discourse.julialang.org/t/psa-documenter-jl-breaking-changes-version-capping/16431
Should fix the Travis failure.
|
Thanks @mortenpi!I don't think PlotDocs is used anywhere else than in the make.jl here. It was not even working until recently, so I don't think this will break anyone's workflow. |
Closed
Merged
BeastyBlacksmith
pushed a commit
that referenced
this pull request
Jun 7, 2022
Switch to Project.toml, cap Documenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a Project.toml, instead of a mix of a
REQUIREfile +Pkg.addcommands to define the environment for the doc build. Also, cap Documenter to 0.19 due to upcoming breaking changes.I am basically just playing around here a bit, trying to figure out what would be a good pattern to use for repositories like this that are not really packages. Doing it this way, I don't think you can have PlotDocs as a package in an environment, so I am guessing it might break people's workflows?