Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenter update #115

Closed
wants to merge 2 commits into from
Closed

Conversation

daschw
Copy link
Member

@daschw daschw commented Oct 30, 2018

No description provided.

@mortenpi
Copy link
Contributor

I happened to notice this, I hope you don't mind some comments 🙂

  • I don't think build stages are really necessary here, as there is no test phase.
  • Pkg.develop(PackageSpec(path=pwd())) will not work here I think, since the repo is not really a package.
  • No need for two different Project.tomls here (as it is not a package). One that sets the environment for the whole thing should be enough.

Is the goal to upgrade to Documenter 0.20? In that case, I think only the following should be necessary:

  • Set [compat] for Documenter to Documenter = "~0.20" in Project.toml.
  • Add DocumenterMarkdown to deps and import it in make.jl
  • Update the makedocs and deploydocs arguments according to the changelog.

@daschw
Copy link
Member Author

daschw commented Nov 20, 2018

Thanks a lot for your helpful comments, @mortenpi!

@daschw daschw closed this Aug 28, 2019
@daschw daschw deleted the documenter-update branch August 28, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants