gr: use new DPI setting for SVG output

[jheinen]

No description provided.

[mkborregaard]

there's a stray then here which breaks this code.

[mkborregaard]

I've pushed a fix for this now.

[mkborregaard]

Hi @jheinen I can see you already merged this, but there's an issue with the Atom integration, where the size of the plot no longer adapts to the plot pane in Atom. @pfitzseb is that best to fix from the Atom side do you think?

[daschw]

We could fix workaround this by checking for the backend in showjuno in output.jl. However, I'm not really a fan of this hidden dpi_factor change. This will result again in situations, where users get a 600x400 image in pyplot and a 2400x1600 image on gr with the same command. Is this really necessary to integrate the GR updates @jheinen?

[jheinen]

The output is ok both in Jupyter and Atom. The width and height attributes in the SVG header don't change, only the viewBox (and all internal coordinates - of course) have a higher resolution (x4)

[mkborregaard]

This is how heatmap(5,5) looks in my Atom on master

[jheinen]

Not for me - are you really using the 0.34.0 run-time?

[mkborregaard]

probably not, though I did the ENV+build thing

[mkborregaard]

Let me try to checkout GR master - maybe we should up the REQUIRE again?

[mkborregaard]

It worked on the new master ❤️ So OK, let's update the GR require version and push a Release once the GR metadata one gets merged.

[mkborregaard]

Or, no, there's still the concern that @daschw mentioned?

[daschw]

The width and height attributes in the SVG header don't change, only the viewBox (and all internal coordinates - of course) have a higher resolution (x4)

I guess that is alright for SVGs then, so my concern should be no problem with the new GR run-time.