Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework adding legends #3732

Closed
wants to merge 1 commit into from
Closed

Rework adding legends #3732

wants to merge 1 commit into from

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jul 31, 2021 •
edited

Disable legend entry when a single series is present and the label has been auto-generated for that series.

Fix #3691.

  • generate ref images → here

@t-bltg t-bltg requested a review from isentropic July 31, 2021 13:44
@t-bltg t-bltg mentioned this pull request Jul 31, 2021
Open
@BeastyBlacksmith BeastyBlacksmith added this to the v2.0 milestone Aug 1, 2021
@BeastyBlacksmith
Copy link
Member

I'd vote to do this in 2.0

@isentropic
Copy link
Member

isentropic commented Aug 2, 2021 •
edited

This is great, I certainly love it, but I do agree we should keep unmerged before 2.0.

@t-bltg
Copy link
Member Author

t-bltg commented Aug 2, 2021

All right, let's reserve this for 2.0.

@t-bltg t-bltg added 2.0 and removed DO NOT MERGE labels Sep 15, 2021
@t-bltg t-bltg mentioned this pull request Nov 28, 2022
Open
19 tasks
@isentropic isentropic mentioned this pull request Jan 12, 2024
Merged
37 tasks
@BeastyBlacksmith BeastyBlacksmith mentioned this pull request Mar 12, 2024
Draft
29 tasks
@t-bltg t-bltg closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isentropic isentropic Awaiting requested review from isentropic

@BeastyBlacksmith BeastyBlacksmith Awaiting requested review from BeastyBlacksmith

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

[FR] legend=false by default for single series plots
3 participants
@t-bltg @BeastyBlacksmith @isentropic