Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to plots 2.0 #4866

Merged
merged 110 commits into from
Mar 12, 2024
Merged

Road to plots 2.0 #4866

merged 110 commits into from
Mar 12, 2024

Conversation

isentropic
Copy link
Member

@isentropic isentropic commented Jan 12, 2024

What changed

  • No default backend
  • Backends are purely extensions with no 'requires'
  • The internals are more organized into modules and moved around, thanks to @BeastyBlacksmith
  • Backend init and backend code is only found in its extensions, this should help with backend interference and annoyances about initialization and precompilation of plots. This should make backends modular and implemented much easier and without hacks into Plots.jl codebase

Example:

using Plots; import UnicodePlots
unicodeplots()
plot(1:10)

What works

  • GR
  • UnicodePlot
  • 90% of tests pass
  • Precompilation

What does not work

Help needed here add more items or resolve the ticks.

  • GR backend has weird axis issue I never got to solve, unicode works consistently same
  • plotly backend
  • pythonplot backend
  • pgfplotsx backend
  • gaston backend
  • default not resetting legend args

Help needed:

  • Rebase on the master branch
  • Report breakages
  • Fix GR backend via help of git diff, something must've changed in GR code
  • move documentation back into this repo
  • Start updating the docs
  • Propose other breaking changes
  • Update the news.md
  • organize a community poll of what defaults could be tweaked and other wishes

Decisions to be made

  • Deprecate inspectDR?
  • Move to column major order?
  • Change the defaults

Issues needing attention please add more or checkoff resolved:
#4565 (comment)
Copy of that:
Labeled issues:

Labeled PRs:


Closes #4326

@isentropic isentropic marked this pull request as draft January 12, 2024 05:07
Copy link
Member

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one step further!

ext/PlotsGRExt/gr.jl Outdated Show resolved Hide resolved
ext/PlotsGRExt/initialization.jl Outdated Show resolved Hide resolved
src/Plots.jl Show resolved Hide resolved
src/abstract_backend.jl Outdated Show resolved Hide resolved
src/abstract_backend.jl Outdated Show resolved Hide resolved
test/test_components.jl Outdated Show resolved Hide resolved
@BeastyBlacksmith
Copy link
Member

I think we are at a point where it makes sense to merge this and then iterate on. I'll copy the OP to the new PR.

@BeastyBlacksmith BeastyBlacksmith marked this pull request as ready for review March 12, 2024 14:52
@BeastyBlacksmith BeastyBlacksmith merged commit c91872b into JuliaPlots:v2 Mar 12, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants