-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add population analysis with error bars across population for continuous plots #30
Changes from all commits
89d83f2
9bcef97
85b0f40
203120c
da11d97
dce15d2
1e6921b
4c40585
5a8319b
4c18e6a
c972da8
3f51641
29bd4f3
4764641
fd10f37
e7c4280
b06ae4b
2d10288
1a874c6
899c87a
41a2251
dc7e1d9
4d65fb7
ff638a5
3ae3845
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ StatsBase | |
Distributions | ||
DataFrames | ||
KernelDensity | ||
Loess | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,11 +9,15 @@ using Distributions | |
using DataFrames | ||
|
||
import KernelDensity | ||
import Loess | ||
@recipe f(k::KernelDensity.UnivariateKDE) = k.x, k.density | ||
@recipe f(k::KernelDensity.BivariateKDE) = k.x, k.y, k.density | ||
|
||
@shorthands cdensity | ||
|
||
export groupapply | ||
export get_groupederror | ||
|
||
include("dataframes.jl") | ||
include("corrplot.jl") | ||
include("cornerplot.jl") | ||
|
@@ -24,5 +28,8 @@ include("hist.jl") | |
include("marginalhist.jl") | ||
include("bar.jl") | ||
include("shadederror.jl") | ||
include("groupederror.jl") | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should export the groupapply function |
||
|
||
end # module |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ grouped_xy(y::AbstractMatrix) = 1:size(y,1), y | |
end | ||
fr | ||
else | ||
get(d, :fillrange, 0) | ||
get(d, :fillrange, nothing) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remind me why you are throwing away the fillrange value here for non-stacked bars? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a fix to: #32 In case of errorbars, the fillrange to 0 also gets applied to the error series and creates those messy things of the issue (on PlotlyJS). Without any fillrange it seems to work just fine. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm I worry what that may have of unintended consequences. Does There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that also works. I'll go for |
||
end | ||
|
||
seriestype := :bar | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding another package here is a bit of debate - I would say that StatPlots should not be afraid of including statistical packages (I guess that is one reason to keep it separate from Plots) and I also think it should depend on GLM - what is your philosophy here, @tbreloff ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this comment. Yes adding dependencies should not be done lightly, but this is probably acceptable.