add errorline.jl #513
Merged
add errorline.jl #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeastyBlacksmith
requested changes
Aug 23, 2022
Co-authored-by: Simon Christ <SimonChrist@gmx.de>
Co-authored-by: Simon Christ <SimonChrist@gmx.de>
Co-authored-by: Simon Christ <SimonChrist@gmx.de>
…ed :raw error mode
|
I believe I've addressed all the changes. The error you got was because NaNMath only accepts Floats so I've added a conversion check. I also added the final distribution mode. I added a new runtest too with Ints as the y values for future checks |
BeastyBlacksmith
approved these changes
Aug 23, 2022
|
I'll add an example or two to the readme in an hour or so
…On Tue, Aug 23, 2022, 7:17 AM Simon Christ ***@***.***> wrote:
***@***.**** approved this pull request.
So far this looks fine to me, there should be at least one example in the
README as Documentation. Would be good to have another pari of eyes here.
—
Reply to this email directly, view it on GitHub
<#513 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6PLUSKKXDEWKY43SF6VI3V2S6L5ANCNFSM57IEPJGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
t-bltg
reviewed
Aug 23, 2022
src/errorline.jl
Outdated
Comment on lines
60
to
64
| if centertype == :mean | ||
| y_central = mapslices(NaNMath.mean, y, dims=2) | ||
| elseif centertype == :median | ||
| y_central = mapslices(NaNMath.median, y, dims=2) | ||
| end |
There was a problem hiding this comment.
Suggested change
| if centertype == :mean | |
| y_central = mapslices(NaNMath.mean, y, dims=2) | |
| elseif centertype == :median | |
| y_central = mapslices(NaNMath.median, y, dims=2) | |
| end | |
| y_central = if centertype == :mean | |
| mapslices(NaNMath.mean, y, dims=2) | |
| elseif centertype == :median | |
| mapslices(NaNMath.median, y, dims=2) | |
| end |
There was a problem hiding this comment.
I don't love that line 60 is a single line, I think it makes it awkward to read, but if broken into two lines I think that's pretty good so I'll do that unless that's against convention?
| num_obs = size(y,2) | ||
| if num_obs > numsecondarylines | ||
| sub_sample_idx = sample(1:num_obs, numsecondarylines, replace=false) | ||
| y_sub_sample = y[:,sub_sample_idx,g] |
There was a problem hiding this comment.
I don't know what convention is used in StatsPlots (maybe we need an autoformatter here as well), but I find y[:, sub_sample_idx, g] more readable.
Co-authored-by: t-bltg <tf.bltg@gmail.com>
Co-authored-by: t-bltg <tf.bltg@gmail.com>
Co-authored-by: t-bltg <tf.bltg@gmail.com>
Co-authored-by: t-bltg <tf.bltg@gmail.com>
Co-authored-by: t-bltg <tf.bltg@gmail.com>
Co-authored-by: t-bltg <tf.bltg@gmail.com>
…mentations of changes from review
|
|
… and bugfix for diff(extrema())
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function for parsing inputs to easily make a ribbons (https://ggplot2.tidyverse.org/reference/geom_ribbon.html) or errorbar https://www.mathworks.com/help/matlab/ref/errorbar.html) plot while allowing for easily controlling error type and also handles NaNs.