Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis to GitHub Actions #133

Closed
wants to merge 2 commits into from
Closed

Migrate from Travis to GitHub Actions #133

wants to merge 2 commits into from

Conversation

DilumAluthge
Copy link

  1. Migrate from Travis to GitHub Actions
  2. Update the TagBot configuration

@DilumAluthge
Copy link
Author

@Evizero Looks like there are a lot of test failures. Any idea what's going on?

@Evizero
Copy link
Member

Evizero commented Apr 14, 2021

is it working locally? looks to me like some fileio incompat

@DilumAluthge
Copy link
Author

The tests also fail for me locally.

Do you know what versions of FileIO, AstroIO, etc. the tests are compatible with?

@Evizero
Copy link
Member

Evizero commented Apr 14, 2021

I am afraid not. I would appreciate the help here

@DilumAluthge
Copy link
Author

The issue is with the ReferenceTests package. You have reference tests in .txt files, but when ReferenceTests tries to load them with FileIO, it interprets the file as being something other than text.

Probably this needs some fixes upstream in ReferenceTests and/or FileIO.

@DilumAluthge DilumAluthge deleted the dpa/github-actions branch April 14, 2021 11:02
@waldyrious
Copy link
Contributor

Text should actually be the default assumption for ReferenceTests — see JuliaTesting/ReferenceTests.jl#27 (/cc @christopher-dG, @oxinabox).

Also, JuliaTesting/ReferenceTests.jl#19 and JuliaTesting/ReferenceTests.jl#73 could potentially be related as well (/cc @juliohm, @johnnychen94).

@johnnychen94
Copy link
Collaborator

Looks like the tests are broken a long time ago. I'm fully scheduled this April but I can take an investigation in May. @Evizero It would be quite convenient if you can send me an invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants