allow customizable RenderMode for txt #19
Conversation
|
Seems sensible. |
that could be nice. another thing to consider is to call the paramter |
|
Good idea |
This commit enables a user to provide a `render` keyword to `@test_reference` for "txt" files, which overwrites the default `RenderMode`. This is useful if the text contains ANSII colors and should not be displayed as a `Diff`, but rather as a `BeforeAfter` (e.g. for testing UnicodePlots).
| @@ -7,7 +7,7 @@ if isinteractive() | |||
| @info ("In interactive use, one should respond \"n\" when the program" | |||
| * " offers to create or replace files associated with some tests.") | |||
| else | |||
| @info ("Four tests should correctly report failure in the transcript" | |||
| @info ("Eight tests should correctly report failure in the transcript" | |||
There was a problem hiding this comment.
how did you count to get to "four" ? if I count all the "complaints" about failing test or non-existing files i got to "seven" before the additional one in this PR. (thought its quite hard to count because the visual separation isn't too great)
|
I changed the keyword to |
|
As an aside thinking about this. |
|
absolutely |
This commit enables a user to provide a
modekeyword to@test_referencefor "txt" files, which overwrites the defaultRenderMode. This is useful if the text contains ANSII colors and should not be displayed as aDiff, but rather as aBeforeAfter.This will allow convenient testing for UnicodePlots ... thats right, its finally happening.