Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat and updates for 0.7 #29

Merged
merged 4 commits into from
Oct 1, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Oct 1, 2018

Now i get:

julia> using CDDLib
[ Info: Precompiling CDDLib [3391f64e-dcde-5f30-b752-e11513730f60]
ERROR: LoadError: LoadError: TypeError: in Type{...} expression, expected UnionAll, got Type{Union{Int64, Size}}
Stacktrace:
 [1] top-level scope at none:0
 [2] include at ./boot.jl:317 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1038
 [4] include at ./sysimg.jl:29 [inlined]
 [5] include(::String) at /Users/forets/.julia/dev/CDDLib/src/CDDLib.jl:3
 [6] top-level scope at none:0
 [7] include at ./boot.jl:317 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1038
 [9] include(::Module, ::String) at ./sysimg.jl:29
 [10] top-level scope at none:2
 [11] eval at ./boot.jl:319 [inlined]
 [12] eval(::Expr) at ./client.jl:399
 [13] top-level scope at ./none:3
in expression starting at /Users/forets/.julia/dev/CDDLib/src/matrix.jl:79
in expression starting at /Users/forets/.julia/dev/CDDLib/src/CDDLib.jl:51
ERROR: Failed to precompile CDDLib [3391f64e-dcde-5f30-b752-e11513730f60] to /Users/forets/.julia/compiled/v0.7/CDDLib/SMSjF.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] macro expansion at ./logging.jl:313 [inlined]
 [3] compilecache(::Base.PkgId, ::String) at ./loading.jl:1185
 [4] _require(::Base.PkgId) at ./logging.jl:311
 [5] require(::Base.PkgId) at ./loading.jl:852
 [6] macro expansion at ./logging.jl:311 [inlined]
 [7] require(::Module, ::Symbol) at ./loading.jl:834

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.464% when pulling 9481e80 on mforets:mforets/updates_0.7 into c5c3633 on JuliaPolyhedra:master.

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          10       10           
  Lines         694      694           
=======================================
  Hits          607      607           
  Misses         87       87
Impacted Files Coverage Δ
src/polyhedra.jl 96.77% <100%> (ø) ⬆️
src/CDDLib.jl 100% <100%> (ø) ⬆️
src/lp.jl 97.33% <100%> (ø) ⬆️
src/matrix.jl 97.61% <100%> (ø) ⬆️
src/mytype.jl 63.63% <72.72%> (ø) ⬆️
src/settype.jl 68% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c3633...9481e80. Read the comment docs.

@mforets
Copy link
Member Author

mforets commented Oct 1, 2018

I can see that the issue is related to the removal of the type parameter N in Polyhedra, such as

function initmatrix(d::Polyhedra.FullDim, ::Type{T}, inequality::Bool, itr::Polyhedra.ElemIt...) where T
    n = d+1
    ...
end

...
mutable struct CDDInequalityMatrix{T <: PolyType, S <: MyType} <: Polyhedra.MixedHRep{T}
...

But i was confused in other places for the required updates in matrix.jl, as in _length(matrix, N), sorry :/

@blegat blegat merged commit 5132068 into JuliaPolyhedra:master Oct 1, 2018
@blegat
Copy link
Member

blegat commented Oct 1, 2018

Polyhedra has dropped Julia v0.6 so there is no need to try to support it here

@mforets mforets deleted the mforets/updates_0.7 branch October 1, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants