Add resetNashSolver() to the public API
#3
Conversation
lrsnashlib.h
Outdated
| @@ -67,7 +67,7 @@ void initFwidth(game *g); | |||
| void updateFwidth(game *g, int col, int pos, char *str); | |||
|
|
|||
|
|
|||
| long FirstTime; /* set this to true for every new game to be solved */ | |||
| extern long FirstTime; /* set this to true for every new game to be solved */ | |||
There was a problem hiding this comment.
My reading of the standard is that every variable must be defined exactly once, and an extern declaration is not a definition.
There was a problem hiding this comment.
then the variable would have internal linkage
|
Can you redirect the change to the branch of #4 ? We won't be making change for the old version of lrslib, let's focus on v7.1a. There the definition in the |
|
Probably even better is to add a function for modifying |
Responded to this in JuliaPolyhedra/LRSLib.jl#41 (comment) |
Absolutely. Thanks for working on the migration! |
In preparation for rebasing this PR onto JuliaPolyhedra#4 This is a backward-incompatible change that will break earlier versions of LRSLib.jl.
bzinberg
changed the title
FirstTime externresetNashSolver() to the public API
Done, and changed the target branch of this PR accordingly. |
Fixes #2.
Tested
Builds successfully on my machine.