Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix depwarn #1042

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix depwarn #1042

merged 2 commits into from
Jun 28, 2023

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Jun 26, 2023

This updates deprecated code introduced in #1039. We found this since our tests using some operations from PyCall.jl with @test_nowarn failed.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.19 ⚠️

Comparison is base (c12d6d7) 67.50% compared to head (c4288c8) 66.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   67.50%   66.32%   -1.19%     
==========================================
  Files          20       20              
  Lines        2025     2022       -3     
==========================================
- Hits         1367     1341      -26     
- Misses        658      681      +23     
Flag Coverage Δ
unittests 66.32% <100.00%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/PyCall.jl 66.35% <100.00%> (-1.55%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevengj stevengj merged commit 2a9f077 into JuliaPy:master Jun 28, 2023
15 of 18 checks passed
@ranocha ranocha deleted the hr/fix_depwarn branch June 28, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants