Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable deepcopy on PyObject #757 #1039

Merged
merged 8 commits into from
Jun 21, 2023
Merged

enable deepcopy on PyObject #757 #1039

merged 8 commits into from
Jun 21, 2023

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Jun 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.49 🎉

Comparison is base (bcaba00) 67.03% compared to head (7ef2c93) 67.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   67.03%   67.52%   +0.49%     
==========================================
  Files          20       20              
  Lines        2017     2023       +6     
==========================================
+ Hits         1352     1366      +14     
+ Misses        665      657       -8     
Flag Coverage Δ
unittests 67.52% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/PyCall.jl 67.90% <100.00%> (+2.80%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevengj
Copy link
Member

stevengj commented Jun 10, 2023

Why not just increment the refcount as proposed in #757?

Or call Python's copy.deepcopy?

src/PyCall.jl Outdated Show resolved Hide resolved
@jw3126
Copy link
Contributor Author

jw3126 commented Jun 13, 2023

@stevengj Does this PR look good to you?

@jw3126
Copy link
Contributor Author

jw3126 commented Jun 21, 2023

@stevengj LGTY?

Project.toml Outdated Show resolved Hide resolved
@stevengj stevengj enabled auto-merge (squash) June 21, 2023 15:25
@stevengj stevengj disabled auto-merge June 21, 2023 16:01
@stevengj stevengj merged commit c12d6d7 into JuliaPy:master Jun 21, 2023
@stevengj stevengj changed the title disable deepcopy on PyObject #757 enable deepcopy on PyObject #757 Jun 21, 2023
@jw3126
Copy link
Contributor Author

jw3126 commented Jun 21, 2023

Thanks, @stevengj can you tag a release?

@stevengj
Copy link
Member

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants