Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't export step #20

Merged
merged 1 commit into from
Mar 2, 2023
Merged

don't export step #20

merged 1 commit into from
Mar 2, 2023

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Mar 2, 2023

According to https://github.com/stevengj/PythonPlot.jl#differences-from-pyplotjl, step is renamed to plotstep to avoid piracy, but it is still exported, causing the following:

julia> using PythonPlot
julia> r = range(0, 1; length=10)
julia> step(r)
WARNING: both PythonPlot and Base export "step"; uses of it in module Main must be qualified
ERROR: UndefVarError: `step` not defined
Stacktrace:
 [1] top-level scope
   @ REPL[4]:1

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@d17c1d5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage        ?   16.03%           
=======================================
  Files           ?        5           
  Lines           ?      449           
  Branches        ?        0           
=======================================
  Hits            ?       72           
  Misses          ?      377           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stevengj stevengj merged commit c41f4bf into JuliaPy:main Mar 2, 2023
@stevengj
Copy link
Member

stevengj commented Mar 2, 2023

Could you make a corresponding PR for PyPlot.jl?

@t-bltg t-bltg deleted the patch-1 branch March 2, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants