Issue 332 (#336)

* bump SpecialFunctions, version number * define abs2 differently; address issue #332
JuliaPy · Feb 25, 2020 · 286ceed · 286ceed · jverzani · Feb 25, 2020
1 parent 115faa5
commit 286ceed
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,7 @@
 name = "SymPy"
 uuid = "24249f21-da20-56a4-8eb1-6a02cf4ae2e6"
-version = "1.0.16"
+version = "1.0.17"
+
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/src/mathfuns.jl b/src/mathfuns.jl
@@ -2,7 +2,7 @@
 
 
 Base.abs(x::SymbolicObject) = sympy.Abs(x)
-Base.abs2(x::SymbolicObject) = abs(x)^2
+Base.abs2(x::SymbolicObject) = x * conj(x)
 Base.max(x::Sym, a) = sympy.Max(x, a)
 Base.min(x::Sym, a) = sympy.Min(x, a)
 

diff --git a/test/tests.jl b/test/tests.jl
@@ -597,6 +597,13 @@ end
     ex = 3 * sympy.E * x
     fn = lambdify(ex)
     @test fn(1) ≈ 3*exp(1) * 1
+
+    ## Issue 332 with `abs2`
+    @vars x real=true
+    @test abs2(x) == x*x
+    @vars x
+    @test abs2(x) == x*conj(x)
+
 end
 
 @testset "generic programming, issue 223" begin