-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for Julia 0.4 #47
Conversation
…call->_call to avoid collision with Julia
Have you tested unitttest with the PyCall #219 and do the test pass? Just curious. I will try your latest changes when I have a minute. In the meantime I found another python library to do what I needed to do with pyjulia but I still would like the option to go back to julia if someonw manage to fix the upgrade to 0.4 + python 3.4+ Thanks! |
@sebastroy good catch, I hadn't updated the tests. They do pass for me now, on both Python 3.4 and 2.7 (on Ubuntu 14.04). |
The Travis build is failing because it's unable to find sys.so. I don't know how to investigate that, can anyone help? Also is there any way to test PyJulia on Windows? |
Travis shouldn't be using the julia binaries from the ppa anymore. Not sure if switching to |
It's probably easier to manually extract the different Julia binaries than it is to switch python versions. For Windows testing, you can try AppVeyor. |
self.api.jl_init_with_image.arg_types = [char_p, char_p] | ||
self.api.jl_init_with_image(JULIA_HOME.encode("utf-8"), | ||
sysimg_relpath.encode("utf-8")) | ||
self.api.julia_init.argtypes = [ctypes.c_int] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why call julia_init
? Is that part of the public API? Shouldn't it be jl_init
?
Is this one outdated? I'm assuming 0.4 support is in (other issue[s] seem to indicate that). Just close or is this for even better support? @benmoran such as for pyjulia on Windows? In case this is not outdated and is useful for Windows (or otherwise) the errors "no environment variables set" seem trivial for someone who know this and/or travis. Any pointers in case I can help? |
I don't think this is outdated. I personnage haven't had time to test these On Tue, Jan 5, 2016 at 7:28 AM, Páll Haraldsson notifications@github.com
|
This is working for me on 0.4, I don't have access to a Windows setup to test it and I don't know how to use AppVeyor. Would love to see it merged. |
The error from Travis is: An example AppVeyor setup is in Example.jl |
I can help setting up AppVeyor, I would really like pyjulia to work on julia 0.4. |
Congrats @benmoran ! 👍 💚 |
It wasn't working inside virtualenvs before, nor on Python 3 - both fixed. I have added an appveyor.yml for Windows tests. The Appveyor build from my fork https://ci.appveyor.com/project/benmoran/pyjulia seems to be taking a very long time - would still appreciate if you could have a look @mmagnuski. Thanks for your help! |
I'll take a look, but my general impression is that AppVeyor is much slower than Travis. Great to see pyjulia finally working. :) |
For some reason your AppVeyor 32-bit builds exceed maximum time, I'm not sure why. Anywany - concerning Windows support, on my Windows 8 I get an error:
Where
The path to
I am not sure how pyjulia comes up with import subprocess
runtime = 'julia'
juliainfo = subprocess.check_output([runtime, "-e", """
println(JULIA_HOME)
println(Libdl.dlpath(Libdl.dlopen(\"libjulia\")))
"""])
|
Depending on what I pass to
The last error message means |
@stevengj has reverted the changes to PyCall.jl that allow this patch to work - you need to checkout PyCall.jl v1.3.0 for this to work now: JuliaPy/PyCall.jl#219 |
Print a lot of debugging messages. Create a minimal executable to interacte with libjulia to find a bug more easily.
More detailed debugging
Partly included in #54. |
To fix #38 (also needs JuliaPy/PyCall.jl#219)