Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #20

Merged
merged 18 commits into from
May 14, 2024
Merged

Fix CI #20

merged 18 commits into from
May 14, 2024

Conversation

mvanzulli
Copy link
Contributor

@mvanzulli mvanzulli commented May 12, 2024

This MR:

  • Fixes CI on main
  • Docs still fails because I haven't maintainer permissions so I can't add Documenter keys. Be a maintainer would speed up dev operations 😇
  • Set coverage
  • Update README including badges 🍡 .

CI passing in my fork: https://github.com/mvanzulli/FinancialDerivatives.jl/actions/runs/9050825985/job/24866677183

@mvanzulli
Copy link
Contributor Author

mvanzulli commented May 12, 2024

@ibis:

This MR should be ready for review. Not sure if sth else is required on the maintainers or devs with permission side to finalize the set-up. Regarding the CD of pages, I think can be a follow-up, but I believe I need permissions to access to the repo keys.

Co-authored-by: Iblis Lin <iblislin@gmail.com>
@iblislin iblislin merged commit a4d5c3a into JuliaQuant:master May 14, 2024
@iblislin
Copy link
Member

iblislin commented May 14, 2024

looks fine

🎉 🎉 🎉

@mvanzulli
Copy link
Contributor Author

looks fine

* https://juliaquant.github.io/FinancialDerivatives.jl/stable/

* https://github.com/JuliaQuant/FinancialDerivatives.jl/actions/runs/9071920106/job/24926539051

🎉 🎉 🎉

Thanks for your review :100

@mvanzulli mvanzulli mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants