Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise parameter n of projection methods #936

Open
mforets opened this issue Dec 5, 2018 · 3 comments
Open

Revise parameter n of projection methods #936

mforets opened this issue Dec 5, 2018 · 3 comments
Labels
simplification 👶 Simplifies code

Comments

@mforets
Copy link
Member

mforets commented Dec 5, 2018

See here.

@mforets mforets changed the title Revise parameter n from projection methods Revise parameter n of projection methods Dec 5, 2018
@mforets mforets added the simplification 👶 Simplifies code label Dec 5, 2018
@schillic
Copy link
Member

schillic commented Dec 5, 2018

What does "revise" mean? I only see the options to remove it or to keep it 😉

@mforets
Copy link
Member Author

mforets commented Dec 5, 2018

😄 Revise in the sense of checking the claim that dim(..) takes microseconds or less for "simple" sets, and only a dozen of microseconds for "complex" lazy sets. If it is the case then i would advocate for removing the parameter n altogether in projection methods, because the dominant part would certainly be the calls to overapproximate.

@schillic
Copy link
Member

schillic commented Dec 5, 2018

I think the reason why we have this parameter is that project is currently only called from decompose in a loop. If we decide to make project public, then of course there can be misuses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification 👶 Simplifies code
Projects
None yet
Development

No branches or pull requests

2 participants