Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#755 - Refactor Zonotopes' reduce_order #1766

Merged
merged 6 commits into from Oct 16, 2019
Merged

#755 - Refactor Zonotopes' reduce_order #1766

merged 6 commits into from Oct 16, 2019

Conversation

SebastianGuadalupe
Copy link
Member

Closes #755 .

@schillic
Copy link
Member

schillic commented Oct 8, 2019

What about this comment?

@mforets
Copy link
Member

mforets commented Oct 10, 2019 •
edited

Here we'd like to not eliminate reduce_order from the LazySets namespaces but rather to have it work as an alias for the overapproximation of a zonotope with another zonotope of given order.

schillic
schillic approved these changes Oct 15, 2019
View reviewed changes
src/Approximations/overapproximate.jl Outdated Show resolved Hide resolved
@mforets mforets merged commit 608c78e into master Oct 16, 2019
@mforets mforets deleted the sebastianguadalupe/755 branch October 16, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Zonotopes' reduce_order
3 participants
@SebastianGuadalupe @schillic @mforets